This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH setup] Make sure that fatal error messages are visible

On 12/20/2017 10:02 PM, Brian Inglis wrote:
On 2017-12-20 10:09, Ken Brown wrote:
On 12/20/2017 11:19 AM, Jon Turney wrote:
On 19/12/2017 00:53, Ken Brown wrote:
The message box produced by TOPLEVEL_CATCH could be hidden by whatever
window was previously being displayed, so that setup appeared to hang.
Fix this by giving fatal error message boxes type MB_SETFOREGROUND.

This is good as far as it goes, but is kind of working around the fact that
fatal() is being called with an NULL owner HWND.

This is not idea because I guess it means that propsheet window is still
activate-able when this messagebox is displayed (MB_APPMODAL doesn't apply)?

It turns out that MB_SYSTEMMODAL did the job.  I tried MB_APPLMODAL and
MB_TASKMODAL also, but both of those still allowed me to activate the propsheet

Is it really a problem if users can look at other windows when there is an
error? It is often useful to be able to look at your inputs to see if they
played a role in causing the error, or it is some external issue.

We're talking about situations in which something unexpected went wrong, and setup has decided that it needs to display an error message, write the log file, and exit. I don't think we want to take a chance on damaging users' systems by letting them interact with the propsheet window at this point.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]