This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed
- From: Jon Turney <jon dot turney at dronecode dot org dot uk>
- To: "cygwin-apps at cygwin dot com" <cygwin-apps at cygwin dot com>
- Date: Sun, 10 Jun 2018 21:57:57 +0100
- Subject: Re: [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed
- References: <20180317145955.4944-1-kbrown@cornell.edu> <20180317145955.4944-2-kbrown@cornell.edu>
On 17/03/2018 14:59, Ken Brown wrote:
The IniDBBuilderPackage destructor contains code that is intended to
be run after each setup.ini file is processed. But the
IniDBBuilderPackage variables in do_local_ini() and do_remote_ini were
declared outside the loop that processed the files. Move the
declaration inside the loop so that the destructor is called after
each iteration.
Applied, thanks.
I need to think a bit more about 2 & 3 in this series and the concerns I
had in [1]
[1 ]https://sourceware.org/ml/cygwin-apps/2018-03/msg00026.html