This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: setup package in Base


On 7/7/2018 8:40 AM, Jon Turney wrote:
On 06/07/2018 15:05, Jon Turney wrote:
On 06/07/2018 14:51, Jon Turney wrote:
Thanks for the patch.

The version is checked (again), at ini.cc:404

I've never understood why we have this twice.

(I think the idea might be that first we are checking the setup version as a proxy for the setup.ini format version, to warn if there might be problems parsing it.  The second time we are checking the setup version to see if an upgrade of setup is possible)

Ah, so now we have setup-minimum-version, checking setup-version: in the ini parser should probably be removed (or disabled when setup-minimum-version: is present?)

Like so:

Yes, this is better than my attempt. I hadn't noticed that setup-version: was checked again in ini.cc.

Ken


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]