This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: Zstandard support for setup
- From: Jon Turney <jon dot turney at dronecode dot org dot uk>
- To: "cygwin-apps at cygwin dot com" <cygwin-apps at cygwin dot com>
- Date: Sun, 7 Oct 2018 20:46:04 +0100
- Subject: Re: Zstandard support for setup
- References: <874lg0d6l8.fsf@Rainer.invalid> <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk> <87r2icl2th.fsf@Rainer.invalid> <87ftyr3k93.fsf@Rainer.invalid>
On 02/09/2018 18:02, Achim Gratz wrote:
Achim Gratz writes:
+ using namespace std;
Please don't
That's a copy from the compress_xz files and it's used in many files
elsewhere. Care to explain why you'd want it removed? If there's a
good reason I'd tend to move this to a clean-up commit that touches all
those files. We should do that before hauling Zstdandard in.
What an unholy mess… Here's that patch, only lightly tested:
http://repo.or.cz/cygwin-setup/local.git/patch/e9802f50304f66984f6aad5544def465e9f8033b
Yeah. Thanks, and sorry for the delay.
Applied.