This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: Zstandard support for setup
- From: Achim Gratz <Stromeko at nexgo dot de>
- To: cygwin-apps at cygwin dot com
- Date: Wed, 10 Oct 2018 20:36:50 +0200
- Subject: Re: Zstandard support for setup
- References: <874lg0d6l8.fsf@Rainer.invalid> <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk>
Jon Turney writes:
> This should check for ztd in configure.ac using PKG_CHECK_MODULES,
> rather than just assuming -lzstd is going to work.
Done.
> + using namespace std;
>
> Please don't
Done.
https://repo.or.cz/cygwin-setup/local.git/patch/fff4b1448072efe5ebb6549cfe04bc15344a3973
> compress_zstd.h:
>
> +/* this is the parent class for all compress IO operations.
> + */
>
> Comment is incorrect
Done in the above, additionally remove the same copy&paste comment from
two existing files:
https://repo.or.cz/cygwin-setup/local.git/patch/abf5afbfce47d1942f6d4c2f62fc8b1566920e2e
> I'd suggest keeping potentially useful ones under #ifdef DEBUG/#endif
> rather than just removing them all.
Later...
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves