This is the mail archive of the cygwin-cvs@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] Remove unused and unsafe call to __builtin_frame_address


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c0b6fc54b1b0025dc02b5e1731ebd4f4aec1bfd0

commit c0b6fc54b1b0025dc02b5e1731ebd4f4aec1bfd0
Author: Peter Foley <pefoley2@pefoley.com>
Date:   Sat Mar 19 13:45:47 2016 -0400

    Remove unused and unsafe call to __builtin_frame_address
    
    initial_sp has been unused since commit fbf23e3 back in 2000.
    Keep the value, so as to avoid changing the offset of magic_biscuit.
    
    winsup/cygwin/lib/_cygwin_crt0_common.cc:140:52:
    error: calling 'void* __builtin_frame_address(unsigned int)' with a
    nonzero argument is unsafe [-Werror=frame-address]
       u->initial_sp = (char *) __builtin_frame_address (1);
    
    winsup/cygwin/ChangeLog
    lib/_cygwin_crt0_common.cc (_cygwin_crt0_common): Initialize initial_sp
    with nullptr.
    
    Signed-off-by: Peter Foley <pefoley2@pefoley.com>

Diff:
---
 winsup/cygwin/lib/_cygwin_crt0_common.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/winsup/cygwin/lib/_cygwin_crt0_common.cc b/winsup/cygwin/lib/_cygwin_crt0_common.cc
index 718ce94..50785d7 100644
--- a/winsup/cygwin/lib/_cygwin_crt0_common.cc
+++ b/winsup/cygwin/lib/_cygwin_crt0_common.cc
@@ -135,9 +135,8 @@ _cygwin_crt0_common (MainFunc f, per_process *u)
   u->premain[3] = cygwin_premain3;
   u->fmode_ptr = &_fmode;
 
-  /* This is used to record what the initial sp was.  The value is needed
-     when copying the parent's stack to the child during a fork.  */
-  u->initial_sp = (char *) __builtin_frame_address (1);
+  /* Unused */
+  u->initial_sp = NULL;
 
   /* Remember whatever the user linked his application with - or
      point to entries in the dll.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]