This is the mail archive of the cygwin-cvs@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] fhandler_disk_file::opendir: Fix a comment


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8b7c4f67c67cfdb59848064417743e57ea9fed40

commit 8b7c4f67c67cfdb59848064417743e57ea9fed40
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Tue Dec 15 17:03:09 2015 +0100

    fhandler_disk_file::opendir: Fix a comment

Diff:
---
 winsup/cygwin/fhandler_disk_file.cc | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/winsup/cygwin/fhandler_disk_file.cc b/winsup/cygwin/fhandler_disk_file.cc
index 6e61ee2..f8abb77 100644
--- a/winsup/cygwin/fhandler_disk_file.cc
+++ b/winsup/cygwin/fhandler_disk_file.cc
@@ -1880,13 +1880,11 @@ fhandler_disk_file::opendir (int fd)
 	      while (!NT_SUCCESS (status));
 	    }
 
-	  /* FileIdBothDirectoryInformation is apparently unsupported on
-	     XP when accessing directories on UDF.  When trying to use it
-	     so, NtQueryDirectoryFile returns with STATUS_ACCESS_VIOLATION.
-	     It's not clear if the call isn't also unsupported on other
-	     OS/FS combinations.  Instead of testing for yet another error
-	     code, let's use FileIdBothDirectoryInformation only on FSes
-	     supporting persistent ACLs, FileBothDirectoryInformation otherwise.
+	  /* FileIdBothDirectoryInformation was unsupported on XP when
+	     accessing UDF.  It's not clear if the call isn't also unsupported
+	     on other OS/FS combinations.  Instead of testing for yet another
+	     error code, use FileIdBothDirectoryInformation only on FSes
+	     supporting persistent ACLs.
 
 	     NFS clients hide dangling symlinks from directory queries,
 	     unless you use the FileNamesInformation info class.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]