This is the mail archive of the cygwin-cvs@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[newlib-cygwin] Cygwin: Fix x86 compiler warning


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=283e0137c784ef2915c148633fa966ba7810fe70

commit 283e0137c784ef2915c148633fa966ba7810fe70
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Wed Feb 7 17:34:59 2018 +0100

    Cygwin: Fix x86 compiler warning
    
    The previous patch introduced a compiler warning on x86.
    
    Given time_t is only 4 bytes on x86 we get a long vs. unsigned long
    comparison in timeval_to_ms.  Fix it by careful casting.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/times.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/times.cc b/winsup/cygwin/times.cc
index 198fc32..677376e 100644
--- a/winsup/cygwin/times.cc
+++ b/winsup/cygwin/times.cc
@@ -223,7 +223,7 @@ timeval_to_ms (const struct timeval *time_in, DWORD &ms)
       || time_in->tv_usec >= USPERSEC)
     return false;
   if ((time_in->tv_sec == 0 && time_in->tv_usec == 0)
-      || time_in->tv_sec >= INFINITE / HZ)
+      || time_in->tv_sec >= (time_t) (INFINITE / HZ))
     ms = INFINITE;
   else
     ms = time_in->tv_sec * HZ + (time_in->tv_usec + (USPERSEC/HZ) - 1)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]