This is the mail archive of the
cygwin-cvs@cygwin.com
mailing list for the Cygwin project.
[newlib-cygwin] Cygwin: fix build with GCC 7
- From: Yaakov Selkowitz <yselkowitz at sourceware dot org>
- To: cygwin-cvs at sourceware dot org
- Date: 17 Apr 2018 20:20:11 -0000
- Subject: [newlib-cygwin] Cygwin: fix build with GCC 7
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=67609efeb0bcb198463a952a6a214813794a9c2b
commit 67609efeb0bcb198463a952a6a214813794a9c2b
Author: Yaakov Selkowitz <yselkowi@redhat.com>
Date: Mon Apr 16 22:46:11 2018 -0500
Cygwin: fix build with GCC 7
GCC 7 is able to see straight through this trick, so use a more formal
method to avoid the warning.
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
Diff:
---
winsup/cygwin/random.cc | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/winsup/cygwin/random.cc b/winsup/cygwin/random.cc
index 802c33b..163fc04 100644
--- a/winsup/cygwin/random.cc
+++ b/winsup/cygwin/random.cc
@@ -279,14 +279,6 @@ srandom(unsigned x)
(void)random();
}
-/* Avoid a compiler warning when we really want to get at the junk in
- an uninitialized variable. */
-static unsigned long
-dummy (unsigned volatile long *x)
-{
- return *x;
-}
-
/*
* srandomdev:
*
@@ -313,7 +305,11 @@ srandomdev()
unsigned long junk;
gettimeofday(&tv, NULL);
- srandom((getpid() << 16) ^ tv.tv_sec ^ tv.tv_usec ^ dummy(&junk));
+ /* Avoid a compiler warning when we really want to get at the
+ junk in an uninitialized variable. */
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+ srandom((getpid() << 16) ^ tv.tv_sec ^ tv.tv_usec ^ junk);
+#pragma GCC diagnostic pop
return;
}