This is the mail archive of the
cygwin-developers@cygwin.com
mailing list for the Cygwin project.
Re: cygthread::cygthread() hang
Christopher Faylor wrote:
>
> On Wed, Apr 09, 2003 at 02:51:55PM -0400, Joe Buehler wrote:
> >At the risk of being annoying: You might check the other uses
> >of VirtualFree(). I notice that there are variations in how
> >it is called from Cygwin.
>
> It seems ok to me. I did this sweep a while ago so this particular
> problem is embarrassing. I should have known better.
>
> However, if someone else wants to double check the current VirtualFree
> usage, I wouldn't mind being show up again.
Chris,
Looks fine to me.
FWIW, a VirtualAlloc with MEM_COMMIT does an implicit MEM_RESERVE when needed.
Thus heap.cc 133:142 should never help.
Also dll_init 145:146 could be combined.
Pierre