This is the mail archive of the
cygwin-developers
mailing list for the Cygwin project.
Re: 64bit: C++ templates
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: cygwin-developers at cygwin dot com
- Date: Wed, 15 May 2013 11:32:36 +0200
- Subject: Re: 64bit: C++ templates
- References: <516CDE32 dot 5000206 at users dot sourceforge dot net> <516F5F89 dot 40600 at users dot sourceforge dot net> <518C9018 dot 9030606 at users dot sourceforge dot net> <CAEwic4aPQHUChVWui6h0FctFkHXh3A0zwh1On50cJRE=SV1UeA at mail dot gmail dot com>
Hi,
the issue is a more general on and related to harfbuzz' use of
-fvisibility-inlines-hidden for mingw-targets, but not for cygwin
targets. Btw the issue should be latent present for 32-bit too.
Well, nevertheless my test have shown that this option indeed fixes
that described issue.
Question here is if we shouldn't make visibility for inlines always
hidden on pe-coff targets. I will think about this a bit. The
following patch would do that:
Regards,
Kai
Index: decl2.c
===================================================================
--- decl2.c (Revision 198882)
+++ decl2.c (Arbeitskopie)
@@ -2308,7 +2308,11 @@ determine_visibility_from_class (tree decl, tree c
static bool
determine_hidden_inline (tree decl)
{
- return (visibility_options.inlines_hidden
+ return ((visibility_options.inlines_hidden
+#ifdef TARGET_PECOFF
+ || TARGET_PECOFF
+#endif
+ )
/* Don't do this for inline templates; specializations might not be
inline, and we don't want them to inherit the hidden
visibility. We'll set it here for all inline instantiations. */