This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [Patch] setup.exe - no skip/keep option buggyness
- To: "Gareth Pearce" <tilps at hotmail dot com>,<cygwin-patches at cygwin dot com>
- Subject: Re: [Patch] setup.exe - no skip/keep option buggyness
- From: "Robert Collins" <robert dot collins at itdomain dot com dot au>
- Date: Sat, 10 Nov 2001 10:46:12 +1100
- References: <F255rNNOCTlI2N76PQ400005c19@hotmail.com>
----- Original Message -----
From: "Gareth Pearce" <tilps@hotmail.com>
To: <robert.collins@itdomain.com.au>; <cygwin-patches@cygwin.com>
...
> Would have submited another go ... but what you have done looks great
(A
> more significant change then I would have submited, but then I am in
newbie
> cautious mode), and I am in the middle of a 336meg download of debian
I've put your patch into the categories branch, and into HEAD.
As for being cautious .... I'll accept any patch, big or small, that
a) is inline with the setup.exe goals. If in doubt the issue can be
discussed to it's death on cyg-apps.
b) is coded well. return values checked, snprintf instead of sprintf
etc.
c) is designed well (IOW doesn't make the internal maintenance harder).
I understand not wanting to spend a lot of time on a big patch, just to
get the patch rejected, so discussing the concept first on cyg-apps is
usually a good idea for non-obvious or structural work.
Rob