This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: src/winsup/w32api ChangeLog include/wingdi.h
- From: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- To: cygwin-patches <cygwin-patches at cygwin dot com>, rbcollins at cygwin dot com
- Date: Fri, 21 Dec 2001 19:00:01 +1100 (EST)
- Subject: Re: src/winsup/w32api ChangeLog include/wingdi.h
--- rbcollins@cygwin.com wrote: > CVSROOT: /cvs/src
> Module name: src
> Changes by: rbcollins@sources.redhat.com 2001-12-20 22:53:57
>
> Modified files:
> winsup/w32api : ChangeLog
> winsup/w32api/include: wingdi.h
>
> Log message:
> 2001-12-21 Robert Collins <rbtcollins@hotmail.com>
>
> * include/wingdi.h: Add GetRandomRgn and SYSRGN.
>
Robert. I know your intentions were good, but please there is no need to
submit to the patch tracker page at mingw SourceForge site as well. That is
for submission of new patches needing review. Unless you make clear that
you have comitted this patch to winsup CVS, it may lead to someone else
(like myself) checking in your patch to the SourceForge CVS (perhaps
modified) leading to conflicts at merging.
Also, in future, keeping to the general layout of existing w32api headers
(defines, then typedefs, then prototypes) would be good. This makes it
easier to protect typedefs and prototypes against RC_INVOKED, while leaving
the constants visible to windres.
Thanks
Danny
http://greetings.yahoo.com.au - Yahoo! Greetings
- Send your festive greetings online!