This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: Terminal input processing fix
On Thu, Feb 28, 2002 at 09:24:40PM +0100, Christian LESTRADE wrote:
> At 18:14 25/02/02 +0100, you wrote:
> >So we could go ahead and apply your patch but... actually I would like
> >to ask you to change it. The reason is that the _POSIX_VDISABLE
> >constant is typically defined in some header file in /usr/include. As
> >is the functionality of CC_EQUAL which is called CCEQ, at least in Linux.
> >
> >So what I'd like you to ask is, could you tweak your patch so that these
> >macros are defined in some appropriate header files, e.g. sys/termios.h?
>
> The _POSIX_VDISABLE and CCEQ defines doesn't (yet) exist in cygwin.
>
> 1. _POSIX_VDISABLE belongs to a set of constants not included yet in
> cygwin. Should I include it alone in sys/termios.h?
>
> 2. CCEQ is only defined in Linux in a BSD context and has not quite the
> same definition as my macro. Should I also include the CCEQ macro in
> sys/termios.h and adapt my code to use it?
Yeah, that's what I'm asking for. I think it has always at least a
minor advantage to have our implementation in Cygwin modelled on
something already existing.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.