This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: serial patch - second attempt


OK, I see.
I have question concerned with minicom. Nicholas asked me about porting
it for serial patch testing so I guess nobody ported it for Cygwin so
far. I took some sources from internet designed for unix-like systems.
Creation of minicom.exe seemed to be  succesfull after some modification
but I have no possibility to test it. Other matter is if anybody is
going to  utilize this software. What do You think about it ?

Jacek

Corinna Vinschen wrote:
> 
> On Wed, Jul 24, 2002 at 10:30:52AM +0200, Jacek Trzcinski wrote:
> > What can I say ? I do not know reason You changed wincap.is_winnt() on
> > wincap.must_init_serial_line(). In my opinion conditionals utilizing
> 
> The reason to use wincap is to not ask for operating systems as far
> as possible but instead to ask for a specific capabilities of the
> system we're just running on.  Nobody actually cares if the system
> is a 95 OSR2 or a NT4 SP5.  CInstead, by using specific capabilities
> the code itself answers the question "why are we doing this" e. g.:
> 
>   if (wincap.has_lseek_bug ())
>     workaround;
> 
> Doesn't that make sense?
> 
> > is_wint() are better but if You do want to change it I suggest something
> > like wincap.support_modem_output_lines_reading
> > which is accurate to function it serves to.
> 
> Ok, I've choosen 'supports_reading_modem_output_lines'
> 
> Corinna
> 
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Developer                                mailto:cygwin@cygwin.com
> Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]