This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: qt patch for winnt.h
- From: Christopher Faylor <cgf at redhat dot com>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 25 Jul 2002 11:48:06 -0400
- Subject: Re: qt patch for winnt.h
- References: <3D401950.1070803@netscape.net>
- Reply-to: cygwin-patches at cygwin dot com
On Thu, Jul 25, 2002 at 11:29:20AM -0400, Nicholas Wourms wrote:
>2002-07-25 Nicholas Wourms <nwourms@netscape.net>
>
> * winnt.h (HANDLE): Add guard for compiling qt.
I really think this sets an incredibly bad precedent. Littering the
system headers with project specific defines is really distasteful
to me.
This is Danny's call, though.
cgf
>Index: winnt.h
>===================================================================
>RCS file: /cvs/src/src/winsup/w32api/include/winnt.h,v
>retrieving revision 1.52
>diff -u -3 -p -u -p -r1.52 winnt.h
>--- winnt.h 17 Jul 2002 03:37:45 -0000 1.52
>+++ winnt.h 25 Jul 2002 15:09:11 -0000
>@@ -108,7 +108,11 @@ typedef const TCHAR *LPCTSTR;
> #define TEXT(q) __TEXT(q)
> typedef SHORT *PSHORT;
> typedef LONG *PLONG;
>+#ifndef QT_CYGWIN /* To allow qt to compile under Cygwin */
> typedef void *HANDLE;
>+#else
>+typedef unsigned int HANDLE;
>+#endif /* QT_CYGWIN */
> typedef HANDLE *PHANDLE,*LPHANDLE;
> #ifdef STRICT
> #define DECLARE_HANDLE(n) typedef struct n##__{int i;}*n