This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: qt patch for winnt.h
- From: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- To: cygwin-patches at cygwin dot com
- Date: Fri, 26 Jul 2002 07:26:33 +1000 (EST)
- Subject: Re: qt patch for winnt.h
--- Christopher Faylor <cgf@redhat.com> wrote: > On Thu, Jul 25, 2002 at
09:43:16PM +0200, Ralf Habacker wrote:
> >> I do prefer feature-centric ifdefs, but I don't think that adding this
> >> particular definition of HANDLE to the windows headers makes sense.
> >
What I don't like is the precedent. Featuritis is catching.
> I'm sure that Danny will comment on this. He's probably doing something
> selfish like sleeping or eating breakfast right now.
And typing on a keyboard -- all at the same time.
I do not like this patch, because it means more work for me when YA typedef
conflict arises and someone else submits a patch (followed by YA long-winded
discussion) to fix that one, and that one breaks someone else's idea of what
the typedef should be and ...
The "standard" for the w32api is MSDN docs. Why can't projects that use the
w32api follow those standards?
Now I'd better unlock the garage and let the kids out.
Danny
> >I'm not sure, how this would look in real code, do you have an example ?
>
> #define HANDLE foo_handle
> #include <winnt.h>
> #undef HANDLE
>
>
> cgf
http://digital.yahoo.com.au - Yahoo! Digital How To
- Get the best out of your PC!