This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ntsec odds and ends


On Wed, Feb 05, 2003 at 11:41:59AM -0500, Pierre A. Humblet wrote:
> 2003-02-05  Pierre Humblet  <pierre.humblet@ieee.org>
> 
> 	* security.h: Introduce names UNKNOWN_UID and UNKNOWN_GID and delete
> 	declaration of is_grp_member.
> 	* uinfo.cc (internal_getlogin): Use UNKNOWN_GID.
> 	* passwd.cc (pwdgrp::read_passwd): Use UNKNOWN_UID.
> 	* grp.cc (pwdgrp::read_group): Change group names to provide better
> 	feedback.
> 	(getgrgid): Use gid16togid32.
> 	* sec_helper.cc (is_grp_member): Delete.

Applied with changes:

> -      char group_name [UNLEN + 1] = "mkgroup";
> +      char group_name [UNLEN + 1] = "run mkgroup";

I didn't commit this change.

> +      if (myself->uid == UNKNOWN_UID)
> +	strcpy (group_name, "run mkpasswd"); /* Feedback... */

I've changed that to just "mkpasswd".

I don't like to introduce group names with spaces in it.  And since they
are longer than 8 chars, they'd get truncated by ls anyway.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]