This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fixing the delete queue security


On Mon, Sep 15, 2003 at 09:18:08PM -0400, Pierre A. Humblet wrote:
>2003-09-15  Pierre Humblet <pierre.humblet@ieee.org>
>
>	* shared_info.h (class user_info): New.
>	(cygwin_user_h): New.
>	(user_shared): New.
>	(enum shared_locations): Replace SH_MOUNT_TABLE by SH_USER_SHARED;
>	(mount_table): Change from variable to macro.
>	* shared.cc: Use sizeof(user_info) in "offsets".
>	(user_shared_initialize): Add "reinit" argument to indicate need
>	to reinitialize the mapping. Replace "mount_table" by "user_shared"
>	throughout. Call user_shared->mountinfo.init and 
>	user_shared->delqueue.init.
>	(shared_info::initialize): Do not call delqueue.init.
>	(memory_init): Add argument to user_shared_initialize.
>	* child_info.h (child_info::mount_h): Delete. 
>	(child_info::user_h): New.	
>	* sigpproc.cc (init_child_info): Use user_h instead of mount_h.
>	* dcrt0.cc (_dll_crt0): Ditto.
>	* fhandler_disk_file.cc (fhandler_disk_file::close): Use 
>	user_shared->delqueue instead of cygwin_shared->delqueue.
>	* fhandler_virtual.cc (fhandler_virtual::close): Ditto.
>	* syscalls.cc (close_all_files): Ditto.
>	(unlink): Ditto.
>	(seteuid32): Add argument to user_shared_initialize.

This is ok.

Please check in.  You'll have to accommodate the new layout after my
checkin but it should apply with only minor problems.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]