This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: fix possible segfault creating detached thread
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Tue, 2 Aug 2005 11:35:12 +0200
- Subject: Re: fix possible segfault creating detached thread
- References: <Pine.LNX.4.61.0508012001310.4694@mgorse.dhs.org>
- Reply-to: cygwin-patches at cygwin dot com
On Aug 1 20:05, Mike Gorse wrote:
> ARGH! I really need to be more careful... Sorry for all the emails.
>
> One last correction...
> 2005-08-01 Michael Gorse <mgorse@alum.wpi.edu>
>
> * thread.cc (pthread::create(3 args)): Make bool.
> (pthread_null::create): Ditto.
> thread.h: Ditto.
>
> * thread.cc (pthread::create(4 args)): Check return of inner
> create rather than calling is_good_object().
Nope, sorry. It should look like this:
2005-08-01 Michael Gorse <mgorse@alum.wpi.edu>
* thread.cc (pthread::create(3 args)): Make bool.
(pthread_null::create): Ditto.
(pthread::create(4 args)): Check return of inner create rather than
calling is_good_object().
* thread.h: Ditto.
Can you please review your patch file? I was unable to apply the patch,
even when using the -l option:
$ patch -l -p0 < ~/thread.diff
patching file thread.cc
Hunk #1 FAILED at 491.
Hunk #2 FAILED at 519.
Hunk #4 FAILED at 3265.
Dunno if that's related to your mail client but maybe it helps to
regenerate the patch file and attach it instead of sending it inline.
Sure, I could apply the changes manually, but that's not how it's
supposed to work, is it?
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader mailto:cygwin@cygwin.com
Red Hat, Inc.