This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to mapping up to 128 SCSI Disk Devices


> > +  else if (drive < 112)          // /dev/sdcs -to- /dev/sddh
> > +    {
> > +      base = DEV_SD6_MAJOR;
> > +      drive -= 96;
> > +    }
> > +  // NOTE: This will cause multiple /dev/sddx entries in
> > +  //       /proc/partitions if there are more than 128 devices
>
> Any problem to fix that and to get rid of this comment?  If not,
> can you please convert the comment to C-style /**/?

We did not attempt to change the implementation due to lack of fully
understanding the implications of how this function is called.  We did
noticed the behavior in /proc/partition when we first attempted to
connect using the stock 1.5.19 cygwin.  Hence, we felt it may help
others to document the behavior.  Our intent is to increase the device
mapping with minimal change to existing implementation.

We have converted all comments to use C-style /**/ and attached the
patch as a file instead.

Thanks,
Joe

Attachment: patch.jl-061114
Description: patch.jl-061114


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]