Re: [patch] poll() return value is actually that of select()

["Craig MacGregor" <cmacgreg at gmail dot com>]

On Dec 12, 2007 1:57 PM, Corinna Vinschen wrote:
>
> Works for me.  How does it break the build for you?  Patch?
>

I get the following error making cygserver... i set up my dev env in a
rush and just wanted a clean build, so i rolled back string.h to 1.8
for a quick fix:

g++ -L/cyg/build/i686-pc-cygwin/winsup
-L/cyg/build/i686-pc-cygwin/winsup/cygwin
-L/cyg/build/i686-pc-cygwin/winsup/w32api/lib -isystem
/cyg/src/winsup/include -isystem /cyg/src/winsup/cygwin/include
-isystem /cyg/src/winsup/w32api/include
-B/cyg/build/i686-pc-cygwin/newlib/ -isystem
/cyg/build/i686-pc-cygwin/newlib/targ-include -isystem
/cyg/src/newlib/libc/include -o cygserver.exe cygserver.o client.o
process.o msg.o sem.o shm.o threaded_queue.o transport.o
transport_pipes.o bsd_helper.o bsd_log.o bsd_mutex.o sysv_msg.o
sysv_sem.o sysv_shm.o
/cyg/build/i686-pc-cygwin/winsup/cygwin/smallprint.o
/cyg/build/i686-pc-cygwin/winsup/cygwin/strfuncs.o
/cyg/build/i686-pc-cygwin/winsup/cygwin/version.o
-L/cyg/build/i686-pc-cygwin/winsup/cygwin -lntdll
bsd_helper.o: In function `_Z17default_tun_checkP10tun_structPcPKc':
/cyg/src/winsup/cygserver/bsd_helper.cc:525: undefined reference to
`_cygwin_strcasecmp@8'
/cyg/src/winsup/cygserver/bsd_helper.cc:525: undefined reference to
`_cygwin_strcasecmp@8'
/cyg/src/winsup/cygserver/bsd_helper.cc:525: undefined reference to
`_cygwin_strcasecmp@8'
/cyg/src/winsup/cygserver/bsd_helper.cc:525: undefined reference to
`_cygwin_strcasecmp@8'
/cyg/src/winsup/cygserver/bsd_helper.cc:525: undefined reference to
`_cygwin_strcasecmp@8'
bsd_helper.o:/cyg/src/winsup/cygserver/bsd_helper.cc:529: more
undefined references to `_cygwin_strcasecmp@8' follow
Info: resolving __ctype_ by linking to __imp___ctype_ (auto-import)
collect2: ld returned 1 exit status
make[3]: *** [cygserver.exe] Error 1
make[3]: Leaving directory `/cyg/build/i686-pc-cygwin/winsup/cygserver'
make[2]: *** [cygserver] Error 1
make[2]: Leaving directory `/cyg/build/i686-pc-cygwin/winsup'
make[1]: *** [all-target-winsup] Error 2
make[1]: Leaving directory `/cyg/build'
make: *** [all] Error 2

> Thanks for the patch.  It looks good to me, but I'll slightly reformat
> it.  I'll rather have the `ir = 1' expressions standalone on a single
> line and curly brackets.  I'll apply it tomorrow.
>

I changed as few lines as possible to avoid the next point :)

> However, this patch is already almost beyond the upper bound (in terms
> of patch size) which we can incorporate without having a signed
> copyright assignment from you, see http://cygwin.com/contrib.html,
> section "Before you get started".  I don't want to keep you from
> providing more and bigger patches, of course, but we all had to go
> through this legal stuff :}
>

I'll make a note to myself to get an agreement out... starting a new
job so I don't know how many more patches I'll be sending in, but it
can't hurt to be ready I suppose.

-craig