This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [Patch] gethostbyname2 again
On Fri, Mar 06, 2009 at 09:41:00AM -0500, Pierre A. Humblet wrote:
>
>----- Original Message -----
>[snip]
I see you've joined the throng of people who duplicate bits from the
header in the body of a message. Do you really need to do this?
>
>| On Tue, Mar 03, 2009 at 12:50:21PM -0500, Pierre A. Humblet wrote:
>| >
>| >To avoid real-time checks, I could do as what dup_ent does, and have 4 versions
>| >of the realloc_ent function, one main one with dst and sz arguments (that one
>| >would be called by dup_ent without any run-time checks) and 3 (actually only
>| >1 is needed for now) that invoke the main one with the correct dst based on the
>| >type of the src argument . The src argument would be null but would have the
>| >right type! That seems to meet your wishes. OK?
>|
>| Yes.
>
>OK, here it the patch for realloc_ent. See also attachement.
>The third chunk (the change to dup_ent) is not essential.
>
>In addition in the patch that Corinna sent on March 3, the line
>+ ret = (hostent *) realloc_ent (sz, unionent::t_hostent);
>should be changed to
>ret = realloc_ent (sz, (hostent *) NULL);
>
>In the Changelog the line
> (dup_ent): Remove dst argument and call realloc_ent.
>should either be deleted or "Remove dst argument and c" should
>be replaced by "C".
This is ok with one very minor formatting nit. Please check in with an
appropriate changelog.
>+static inline hostent *
>+realloc_ent (int sz, hostent * )
^
extra space
cgf