This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Provide sys/xattr.h


On Mar 29 09:53, Corinna Vinschen wrote:
> On Mar 29 02:43, Yaakov (Cygwin/X) wrote:
> > Historically, the *xattr functions were first provided by SGI libattr
> > and prototyped in <attr/xattr.h>.  Later, glibc added them under
> > <sys/xattr.h>[1], and (on Linux) libattr still provides the symbols for
> > ABI compatibility but they are now just wrappers.
> > 
> > (FWIW, Darwin also provides these symbols in <sys/xattr.h>[2].)
> > 
> > This can be seen very clearly in GLib's configure[3], where
> > <sys/xattr.h> and libc are tested in tandem, followed by <attr/xattr.h>
> > and libattr.  Hence, with only attr/xattr.h present, libattr-devel is
> > required not only for building GLib, but the -lattr becomes hardcoded in
> > the libtool .la files, meaning that libglib2.0-devel would require
> > libattr-devel even though GLib requires no symbols from libattr1.
> > 
> > I see two ways to resolve this:
> > 
> > 1) Move include/attr/xattr.h to include/sys/xattr.h, and ship libattr's
> > attr/xattr.h in libattr-devel, exactly as is done on Linux:
> > 
> > 2011-03-29  Yaakov Selkowitz <yselkowitz@...>
> > 
> > 	* include/attr/xattr.h: Move from here...
> > 	* include/sys/xattr.h: ...to here.
> > 
> > 2) Install a copy of include/attr/xattr.h as <sys/xattr.h>, as in the
> > attached patch.
> 
> What about just creating a file sys/attr.h which includes attr/attr.h?

Well, with 'x', of course.  Like this:

=== SNIP ===
/* sys/xattr.h

   Copyright 2011 Red Hat, Inc.

This file is part of Cygwin.

This software is a copyrighted work licensed under the terms of the
Cygwin license.  Please consult the file "CYGWIN_LICENSE" for
details. */

/* sys/xattr.h header file for Cygwin.  */

#ifndef _SYS_XATTR_H
#define _SYS_XATTR_H

#include <attr/xattr.h>

#endif /* _SYS_XATTR_H */
=== SNAP ===


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]