Re: initialize local variable wait_return

[Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>]

On Wed, May 04, 2011 at 05:17:31AM -0500, Yaakov (Cygwin/X) wrote:
>On Wed, 2011-05-04 at 02:03 -0400, Christopher Faylor wrote:
>> On Wed, May 04, 2011 at 11:11:52AM +0800, Chiheng Xu wrote:
>> >2011-05-04  Chiheng Xu  <chiheng.xu@gmail.com>
>> >
>> >       * fhandler.cc (fhandler_base_overlapped::wait_overlapped): initialize
>> >local variable wait_return , otherwise, gcc-4.3.4 will not compile it.
>> 
>> Sorry but this is the wrong solution to this problem.  I rewrote the
>> code recently to carefully set error conditions at each decision point.
>> Globally setting it at the beginning is a step backwards and it actually
>> masks the real problem.
>
>FWIW, I regularly build CVS with gcc-4.5, and there is currently no
>compilation problem.

I actually fixed this problem last night by marking a few functions as
__attribute__ ((noreturn)).  That eliminated the need to spuriously set
a variable to zero to quiet gcc.

cgf