This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Aug 16 09:24, Eric Blake wrote:Not sure how to interpret exactly what it mentions. Anyway, my updated patch (using MB_LEN_MAX) proposes a change here as well.On 08/16/2012 08:20 AM, Thomas Wolff wrote:
MB_CUR_MAX does not work because its value is 1 at this pointSo what about MB_LEN_MAX then? There's no problem using a multiplier, but a symbolic constant is always better than a numerical constant.I've now used _MB_LEN_MAX from newlib.h, rather than MB_LEN_MAX from limits.h (note the "_" distinction :) ), because the latter, by its preceding comment, reserves the option to be changed into a dynamic function in the future, which could then possibly have the same problems as MB_CUR_MAX.POSIX requires MB_LEN_MAX to be a constant, only MB_CUR_MAX can be dynamic. We cannot change MB_LEN_MAX to be dynamic in the future....also, Cygwin's include/limits.h doesn't mention to convert to a function.
Attachment:
clipboard-small-buffer.patch.4
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |