This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [patch]: Decouple cygwin building from in-tree mingw/w32api building
On Wed, Oct 17, 2012 at 07:05:14PM +0200, Corinna Vinschen wrote:
>On Oct 17 12:44, Christopher Faylor wrote:
>> >Index: winsup/Makefile.common
>> >===================================================================
>> >RCS file: /cvs/src/src/winsup/Makefile.common,v
>> >retrieving revision 1.59
>> >diff -p -u -3 -r1.59 Makefile.common
>> >--- winsup/Makefile.common 30 Jul 2012 04:43:21 -0000 1.59
>> >+++ winsup/Makefile.common 17 Oct 2012 15:21:32 -0000
>>
>> Can we just get rid of this as well? That's what I did in my now-unneeded
>> revamp of the configury in the cygwin git repository.
>>
>> I think I'd rather just move everything into winsup, cygserver, utils and
>> not bother with this "common" stuff.
>
>But it's still a nice way to have certain definitions only once.
>The BSD build systems use something similar.
The BSD build system has multiple common include makefiles. I use it
every day. You have to look in multiple different places to find
makefile settings. Although it obviously works, and I've gotten used to
it in the last several years, I find it mildly frustrating to work with
when you need to control how something is built because it isn't always
clear where settings are coming from.
When I created Makefile.common I thought I was doing a good thing just
so that you could have certain definitions more than once however, these
days, I think it makes more sense to use a common configure
infrastructure which produces similar Makefiles. I've been bitten more
than once by making changes to winsup/Makefile and finding that it
doesn't do what I expected thanks to Makefile.common.
But, anyway, nevermind. This shouldn't be a requirement for getting
these changes checked in. I'm more concerned with just nuking the
now-unneeded mingw script.
cgf