This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Cygwin: fix guard on struct siginfo_t


On Jul  7 17:38, Yaakov Selkowitz wrote:
> Add line breaks to make it clearer that the struct packing applies to more
> than one struct.
> 
> Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
> ---
> We probably should consider a 2.8.2 sooner rather than later.
> 
>  winsup/cygwin/include/cygwin/signal.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/winsup/cygwin/include/cygwin/signal.h b/winsup/cygwin/include/cygwin/signal.h
> index e73874c62..af0833688 100644
> --- a/winsup/cygwin/include/cygwin/signal.h
> +++ b/winsup/cygwin/include/cygwin/signal.h
> @@ -175,7 +175,10 @@ typedef struct sigevent
>    pthread_attr_t *sigev_notify_attributes; /* notification attributes */
>  } sigevent_t;
>  
> +#if __POSIX_VISIBLE >= 199309
> +
>  #pragma pack(push,4)
> +
>  struct _sigcommune
>  {
>    __uint32_t _si_code;
> @@ -190,8 +193,6 @@ struct _sigcommune
>    };
>  };
>  
> -#if __POSIX_VISIBLE >= 199309
> -
>  #define __SI_PAD_SIZE 32
>  #ifdef __INSIDE_CYGWIN__
>  # ifndef max
> @@ -251,6 +252,7 @@ typedef struct
>  #endif /*__INSIDE_CYGWIN__*/
>    };
>  } siginfo_t;
> +
>  #pragma pack(pop)
>  
>  #endif /* __POSIX_VISIBLE >= 199309 */
> -- 
> 2.12.3

ACK, please push.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]