newlib-cygwin build fails on dumper

[Corinna Vinschen]

On Mar 14 10:10, Brian Inglis wrote:
> Hi folks,
> 
> During newlib-cygwin build to test patches, with latest current stable
> packages as of last weekend, and yesterday's repo main/master, get a
> warning, then errors building dumper:
> 
> ...
> 
>   CC       libc/reent/libc_a-getentropyr.o
> /usr/src/newlib-cygwin/newlib/libc/reent/getentropyr.c: In function ‘_getentropy_r’:
> /usr/src/newlib-cygwin/newlib/libc/reent/getentropyr.c:48:14: warning:
> implicit declaration of function ‘_getentropy’; did you mean ‘getentropy’?
> [-Wimplicit-function-declaration]
>    48 |   if ((ret = _getentropy (buf, buflen)) == -1 && errno != 0)
>       |              ^~~~~~~~~~~
>       |              getentropy
> 
> ...
> 
>   CXX      dumper-dumper.o
> In file included from /usr/src/newlib-cygwin/winsup/utils/dumper.cc:23:
> /usr/include/bfd.h:2748:1: error: expected initializer before
> ‘ATTRIBUTE_WARN_UNUSED_RESULT’
>  2748 | ATTRIBUTE_WARN_UNUSED_RESULT;
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/include/bfd.h:2751:1: error: expected initializer before

I'm pretty sure this isn't the latest newlib-cygwin main.

The getentropy warning has been fixed on 2023-09-25 by commit
a9e8e3d1cb82 ("newlib: Add missing prototype for _getentropy")

The ATTRIBUTE_WARN_UNUSED_RESULT error message has been fixed on
2024-02-12 by commit 10c8c1cf4f94 ("include/ansidecl.h: import from
binutils-gdb")


Corinna