This is the mail archive of the cygwin@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] ls & "magic" cygdrive dir (was: RE: cygdrive stuff)


On Tue, Sep 25, 2001 at 09:22:08AM +1000, Robert Collins wrote:
>----- Original Message -----
>From: "Li-Kai Liu" <news@likai.net>
>
>> however, files and file systems are two different concepts! fhandler
>
>Corinna has already indicated that this is the desired end direction,
>with one class hierarchy for fs's and one for files.
>
>> apparently it is not the way it is right now in cygwin. :(
>
>Exactly. However making the readdir and opendir calls use objects and
>stop being hardcoded to win32 is a good step in the right direction.
>
>> to code the way i want them to. i'll genuinely code this thing if I
>know
>> that people like my idea and so it won't end up being hated and
>discarded.
>
>It won't end up being hated and discarded :]. I strongly suggest a
>one-step-at-a-time approach though: a series of small patches that make
>specific changes to get from here to there. Biting off too much is a
>common reason for architectural changes to fail.

Yes, what he said.

With any free software project, small incremental changes are the
best way to get things done.

One other thing to point out is that if your patches involve
gratuitous changes to other parts of the code, if they are
formatted "incorrectly", if they don't include a ChangeLog
entry (not a *patch* of a ChangeLog entry), if the ChangeLog
entry is formatted incorrectly or has odd wording, then these
are also obstacles to getting a patch included.

Basically, you want to make the patch easy to read and problem-free.
Then people are apt to read them and comment on them.

cgf

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]