This is the mail archive of the
cygwin
mailing list for the Cygwin project.
Re: [Patch] Fix gethwnd race
- From: Jacek Trzmiel <sc0rp at hot dot pl>
- To: cygwin at cygwin dot com
- Date: Fri, 07 May 2004 17:53:18 +0200
- Subject: Re: [Patch] Fix gethwnd race
- References: <Pine.CYG.4.58.0405061902370.636@fordpc.vss.fsi.com> <20040507032703.GA950@coe.bosbc.com> <409BA27E.379C0E06@hot.pl> <20040507151447.GE3107@coe.bosbc.com>
(Redirected from cygwin-patches)
http://cygwin.com/ml/cygwin-patches/2004-q2/msg00082.html
>>> On Thu, May 06, 2004 at 07:18:39PM -0500, Brian Ford wrote:
>>>>Although not the complete rewrite you may have been hoping for, the
>>>>attached patch does appear to fix the: Winmain: Cannot register window
>>>>class, Win32 error 1410 portion of this bug:
>>>>http://www.cygwin.com/ml/cygwin/2004-05/msg00232.html
>>Christopher Faylor wrote:
>>>Thanks, but, I see that you're using busy loops. I use those in places
>>>where I have no choice but to do so or when the potential for a race is
>>>unlikely.
>>>
>>>I don't think that this is really a situation that qualifies for
>>>either. It seems like a muto is a cleaner choice here.
>On Fri, May 07, 2004 at 04:51:42PM +0200, Jacek Trzmiel wrote:
>>I can change it to use critical section. I just have one question -
>>where would be good place to put InitializeCriticalSection call?
Christopher Faylor wrote:
> Please read what I said: "It seems like a muto is a cleaner choice
> here." muto != critical section.
I've realized what you have meant by writing 'muto' just after sending
mail - found it in sync.h.
> I'm sure Brian can make the appropriate changes. Let's give him the
> opportunity to do so.
I'm sure he can. However I don't see anything wrong with with trying to
patch it myself. Even if my patch won't be accepted, I can learn
something new by writing it. Just need a little helping hand from
someone familiar with cygwin sources: where will be good place to put
new_muto() call?
BTW. Which list is more appropriate for such questions cygwin or
cygwin-patches?
Best regards,
Jacek.
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/