This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: please fix heap_init


On Jul 18 09:11, Corinna Vinschen wrote:
> On Jul 18 05:20, jojelino wrote:
> > this is following of 'infinite recursion in git-svn'
> > #to reproduce this problem,
> > #1. please use latest cvs trunk
> > #2. set HKEY_LOCAL_MACHINE\SOFTWARE\Cygwin\heap_chunk_in_mb=0x400
> > Starting program: /usr/bin/perl.exe /usr/lib/git-core/git-svn clone
> > -rHEAD http://google-perftools.googlecode.com/svn/trunk/
> > [New Thread 5352.0x9c4]
> > warning: section .gnu_debuglink not found in
> > /cygdrive/d/cygwin/bin/cygwin1.dbg
> > 
> > Breakpoint 1, heap_init () at /tmp/winsup/winsup/cygwin/heap.cc:81
> > 81                    start_address = roundup2 (start_address +
> > mbi.RegionSize,
> > 2: largest_found_size = 0x35680000
> > 1: start_address = 0x55690000
> > (gdb) i b
> > Num     Type           Disp Enb Address    What
> > 1       breakpoint     keep y   0x61078875 in heap_init()
> >                                            at
> > /tmp/winsup/winsup/cygwin/heap.cc:81
> >         breakpoint already hit 1 time
> > (gdb)
> > 
> > start_address continues to grow, and in heap.cc:94 it is used as
> > base address.
> > which is not we wanted. and sbrk could fail if it used up MINHEAP_SIZE.
> 
> This is what we want.  Did you compare the behaviour of the code with
> the comments in the code?  Can you please *explain* what is wrong with
> the code?

I had a closer look and I found a bug in the code.  When no memory area
has been found which is bigger than the requested memory area, the code
was supposed to allocate the largest memory area found.  At this point
the code used start_address accidentally, rather than largest_found.
Is that what you were refering to?  If so, that should be fixed now in
CVS.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]