Re: Group Permissions on root folders problem (Windows 10 TP build 10061)

[Eric Blake <eblake at redhat dot com>]

On 09/10/2015 11:23 AM, Corinna Vinschen wrote:
> On Sep 10 20:04, Takashi Yano wrote:
>> Hi Corinna,
>>
>>> However, I have not the faintest idea why the cyg_server stuff doesn't
>>> work.  Anybody willing to track this down in the csih helper script?
>>
>> I had looked into csih script, and found a patch below solves
>> the second problem.
>>>> b) Creating sshd service using cyg_server
>>
>> --- cygwin-service-installation-helper.sh.orig	2015-02-24 04:57:56.000000000 +0900
>> +++ cygwin-service-installation-helper.sh	2015-09-10 18:16:38.185042300 +0900
>> @@ -2867,7 +2867,8 @@
>>      if ! csih_use_file_etc "passwd"
>>      then
>>        # This test succeeds on domain member machines only, not on DCs.
>> -      if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" ]
>> +      if [ "\\\\${COMPUTERNAME,,*}" != "${LOGONSERVER,,*}" \
>> +	   -a "${LOGONSERVER}" != "\\\\MicrosoftAccount" ]
>>        then
>>  	# Lowercase of USERDOMAIN
>>        	csih_PRIVILEGED_USERNAME="${COMPUTERNAME,,*}+${username}"
> 
> Thanks a lot, much appreciated.  Patch applied.

[ ... -a ... ] is not portable; there are some inherently ambiguous
situations that it cannot handle. POSIX recommends that you spell it [
... ] && [ ... ] instead.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature