Re: linker fails with multiple definitions after inline thread_local var within class

[Brian Inglis <Brian dot Inglis at SystematicSw dot ab dot ca>]

On 2019-11-14 11:23, Arthur Norman wrote:
> When I run this on Ubuntu-x86_64, Macintosh(clang) or a Raspberry pi the code
> links and when it runs it just prints 999 - which is the behaviour that I
> expect. On both Cygwin and using x86_64-w64-mingw32-g++  (and i686) I get a
> linker diagnostic of the form> ./tltest.sh
> /usr/lib/gcc/x86_64-pc-cygwin/8.3.0/../../../../x86_64-pc-cygwin/bin/ld:
>   /tmp/cczVTcZ1.o:t2.cpp:(.text+0x86): multiple definition of
>   `TLS init function for Data::valref';
>   /tmp/ccyLQlRb.o:t1.cpp:(.text+0x4a): first defined here
> collect2: error: ld returned 1 exit status
>
> I believe that given the specification of C++17 "inline" variables this is
> incorrect, but there are better experts who may be able to explain 
> otherwise.>
> When people raise issues here I often see other asking "Why are you doing 
> that?". This is a cut-down version of my real code where rather than storing
> a reference to the thread_local Record that I am interested in in a simple
> array (tvec) at a fixed offset (1) I store and retrieve a referece to it
> using TlsAlloc(), TlsGetValue and TlsSetValue - those being the Microsoft API
> for thread-local access, and for my purposes my measurements suggest that
> using them gives me useful performance gains over the emutls code that g++
> creates on the relevant platforms.> And I am then (trying to) build a header-only library (for which t.h is the
> surrogate here) which can be included from several other compilation units
> but by virtue of "inline variables" its private (including thread- local)
> date can be defined within that header file  so that the files that #include
> the header-only library do not need to contain anything beyond uses of it. To
> illustrate this I have two source files which each include t.h but the bad
> behaviour does not need any other code in the first one! The second just
> contains a tiny main program that inspects data from the library data.>
> Have I misunderstood C++ and so am I doing something wrong or is this a
> g++/Windows bug?
You appear to be running into a conflict with Cygwin managing Windows TLS, as
Cygwin does its own messing around to support Unix/Linux/POSIX/g++ semantics for
TLS and everything else under Windows. You should either use the supplied API,
or write a Windows program that allows you to control TLS within Windows rules
on what you can do with it. Otherwise you will have to get deep into the
changeable and not directly supported underbelly of the Cygwin implementation.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple