[PATCH v2 1/2] Add support for Hexagon

Mark Wielaard mark@klomp.org
Thu Apr 4 16:51:29 GMT 2024


Hi Matheus,

On Tue, 2024-04-02 at 16:55 -0300, Matheus Tavares Bernardino wrote:
> This implements initial support for the Hexagon architecture. The
> Hexagon ABI spec can be seen at
> https://lists.llvm.org/pipermail/llvm-dev/attachments/20190916/21516a52/attachment-0001.pdf
> 
> A hello_hexagon.ko test is also added.
> 
> $ head tests/test-suite.log
>   [...]
>   # TOTAL: 275
>   # PASS:  269
>   # SKIP:  6
>   # XFAIL: 0
>   # FAIL:  0
>   # XPASS: 0
>   # ERROR: 0
> 
> $ cat tests/run-strip-reloc-ko.sh.log
>   [...]
>   runtest hello_hexagon.ko
>   PASS run-strip-reloc-ko.sh (exit status: 0)

Very nice. Thanks for including the new testcase. Now we have at least
a little test coverage that can be run on any arch to check hexagon is
supported.

The only thing I did before pushing this was to add a ChangeLog entry
to the commit message:

    * backends/Makefile.am (modules): Add hexagon.
    (hexagon_SRCS): New var for hexagon_init.c and hexagon_symbol.c.
    (libebl_backends_a_SOURCES): Add hexagon_SRCS.
    * backends/hexagon_init.c: New file.
    * backends/hexagon_reloc.def: Likewise.
    * backends/hexagon_symbol.c: Likewise.
    * libebl/eblopenbackend.c (hexagon_init): Declare.
    (machines): Add hexagon.
    * libelf/elf-knowledge.h: Add hexagon e_flags values, section
    indices and and relocs.
    * src/elflint.c (valid_e_machine): Add EM_QDSP6.
    * tests/Makefile.am (EXTRA_DIST): Add hello_hexagon.ko.bz2.
    * tests/hello_hexagon.ko.bz2: New test file.
    * tests/run-strip-reloc-ko.sh: Add hello_hexagon.ko.

This is mainly for my own review, so I know all changes were actually
intended.

Pushed,

Mark


More information about the Elfutils-devel mailing list