[RFA]: Change to_stopped_data_address ABI

[Jeff Johnston]

Eli Zaretskii wrote:
>>Date: Mon, 20 Sep 2004 17:35:17 -0400
>>From: Jeff Johnston <jjohnstn@redhat.com>
>>Cc: gdb-patches@sources.redhat.com
>>
>>Ping.  I hope I clarified Eli's questions already.
> 
> 
> I'm not sure you did; there was a contradiction between the intended
> change of the interface and the actual code that was never resolved.
> 
> Andrew expressed his concerns in this message:
> 
>   http://sources.redhat.com/ml/gdb-patches/2004-09/msg00064.html
> 
> Also, in the future, please try to preserve the References header
> in your mail, so that the thread history could be traced easier.
>

Thanks Eli.  I didn't see Andrew's posting.  Some screw-up with my mail reader.
Anyway, I have reworked the code per Andrew's suggestions.  It makes the doc 
stuff much simpler and with the changes I have made, watching address zero is 
now supported.

Andrew/Eli, ok to commit?  Did I miss anything?

Built on x86-linux, x86-64-linux, and ia64-linux.

-- Jeff J.

2004-09-24  Jeff Johnston  <jjohnstn@redhat.com>

         * target.h (to_stopped_data_address): Change prototype to
         take a CORE_ADDR pointer and return an int.
         * target.c (update_current_target): Change to_stopped_data_address
         to match new prototype.
         (debug_to_stopped_data_address): Change appropriately.
         * breakpoint.c (bpstat_stop_status): Change call to
         target_stopped_data_address to use new prototype.
         * frv-tdep.c (frv_have_stopped_data_address): New function.
         (frv_stopped_data_address): Change to new prototype and
         functionality.
         * ia64-linux-nat.c (ia64_stopped_data_address): Change to new
         prototype and functionality.
         (ia64_stopped_by_watchpoint): New function.
         * i386-nat.c (i386_stopped_data_address): Change to new
         prototype and functionality.
         (i386_stopped_by_watchpoint): New function.
         * remote.c (remote_stopped_data_address): Change to new prototype
         and functionality.
         * remote-m32r-sdi.c (m32r_stopped_data_address): Ditto.
         * config/frv/tm-frv.h (frv_stopped_data_address): Change prototype.
         (STOPPED_BY_WATCHPOINT): Change to use frv_have_stopped_data_address.
         * config/i386/nm-i386.h (STOPPED_BY_WATCHPOINT): Change to use
         new i386_stopped_by_watchpoint function.
         (i386_stopped_by_watchpoint): New prototype.
         (i386_stoppped_data_address): Change to new prototype.
         * config/ia64/nm-linux.h (STOPPED_BY_WATCHPOINT): Change to use
         new ia64_stopped_by_watchpoint function.
         (ia64_stopped_by_watchpoint): New prototype.
         (ia64_stopped_data_address): Ditto.

doc/ChangeLog:

2004-09-24  Jeff Johnston  <jjohnstn@redhat.com>

         * gdbint.texinfo (target_stopped_data_address): Update to
         new prototype.
         (i386_stopped_data_address): Update prototype and description.
         (i386_stopped_by_watchpoint): New function and description.



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: new.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20040924/23b56895/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: doc.patch
URL: <http://sourceware.org/pipermail/gdb-patches/attachments/20040924/23b56895/attachment-0001.ksh>