[RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems

Joel Brobecker brobecker@adacore.com
Mon Apr 2 07:01:00 GMT 2007


> Sorry for chiming in only now, but I have a few minor comments:

Not a problem at all, Eli. I am not able to followup on them right
now, but I promise I will in a few days.

> >   for (;;)
> >     {
> >       int c1 = tolower (*s1);
> >       int c2 = tolower (*s2);
> 
> Are we sure that strncasecmp's behavior wrt to locales is identical to
> that of tolower's?  If not, the above will introduce a bug in
> non-English locales.

For this question, I'm not sure, actually.

-- 
Joel



More information about the Gdb-patches mailing list