[PATCH] Fix _itoa_lower_digits (was Re: bootstrap 2.95 libc not building on alpha)

Ulrich Drepper drepper@redhat.com
Wed Mar 13 15:13:00 GMT 2002


On Wed, 2002-03-13 at 08:36, Jakub Jelinek wrote:

> I think we should use _itoa_lower_digits_internal to avoid confusion.
> The above error is because rtld.c used stdio-common/_itoa.h while
> dl-reloc.c and dl-minimal.c used/defined _itoa_lower_digits explicitely.

This shouldn't be necessary but so be it.  I've applied the patch.


> BTW: It is wrong that mp_clz_tab.c is "Not needed anywhere",

Because I haven't looked everywhere I haven't removed the file.

> it is
> just not needed anywhere on certain arches. I'd think the best thing to do
> would be to put them back, make __clz_tab hidden (but am not sure if
> it should be in stdlib/longlong.h header (as e.g. gcc is not interested in
> such changes),

The file is not going back for all archs.  Any change will have to
happen in an architecture-dependent Makefile.  How the attribute is
added is another problem.

Platforms oher than x86 are really not optimized in the moment so there
is no need for such an isolated attempt at this time.  Once I'm through
I'll look at ia64 and alpha but all the rest remains for others.  A lot
of the optimizations are generic but still there is work to do.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 232 bytes
Desc: This is a digitally signed message part
URL: <http://sourceware.org/pipermail/libc-hacker/attachments/20020313/81eb9c7e/attachment.sig>


More information about the Libc-hacker mailing list