fix .../linux/errlist.c
Andreas Jaeger
aj@suse.de
Sun May 19 23:47:00 GMT 2002
Ulrich Drepper <drepper@redhat.com> writes:
> On Sun, 2002-05-19 at 09:38, Andreas Jaeger wrote:
>>ware; you can redistribute it and/or
>> @@ -37,8 +37,8 @@ extern const char *const *__old_sys_errl
>>
>> const int __old_sys_nerr = OLD_ERRLIST_SIZE;
>>
>> -strong_alias (__old_sys_nerr, _old_sys_nerr);
>> weak_alias (__old_sys_nerr, _old_sys_nerr)
>> +strong_alias (__old_sys_nerr, _old_sys_nerr);
>
> This doesn't look OK? Why is there a weak and a strong alias for the
> same pair of names? Please test this patch:
I see. Yes, that patch fixes the problem. Can you commit it to both
branches?
Thanks,
Andreas
>
> Index: errlist.c
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/errlist.c,v
> retrieving revision 1.8
> diff -d -u -p -r1.8 errlist.c
> --- errlist.c 6 Jul 2001 04:56:12 -0000 1.8
> +++ errlist.c 20 May 2002 06:40:44 -0000
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 1998, 2000 Free Software Foundation, Inc.
> +/* Copyright (C) 1998, 2000, 2002 Free Software Foundation, Inc.
> This file is part of the GNU C Library.
>
> The GNU C Library is free software; you can redistribute it and/or
> @@ -38,10 +38,9 @@ extern const char *const *__old_sys_errl
> const int __old_sys_nerr = OLD_ERRLIST_SIZE;
>
> strong_alias (__old_sys_nerr, _old_sys_nerr);
> -weak_alias (__old_sys_nerr, _old_sys_nerr)
> compat_symbol (libc, __old_sys_nerr, _sys_nerr, GLIBC_2_0);
> compat_symbol (libc, _old_sys_nerr, sys_nerr, GLIBC_2_0);
> -weak_alias (__old_sys_errlist, _old_sys_errlist);
> +strong_alias (__old_sys_errlist, _old_sys_errlist);
> compat_symbol (libc, __old_sys_errlist, _sys_errlist, GLIBC_2_0);
> compat_symbol (libc, _old_sys_errlist, sys_errlist, GLIBC_2_0);
> #endif
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj
More information about the Libc-hacker
mailing list