[PATCH] SH: Fixup pread/pwrite

Ulrich Drepper drepper@redhat.com
Thu Aug 26 09:12:00 GMT 2004


Kaz Kojima wrote:

> The pread/write* stuff of sh-linux just includes the mips one and now
> the mips implementation uses more mips specific things like sgidefs.h
> which doesn't exist on SH.  The appended patch just copies them and
> removes the mips specific lines from them.

Yeah, but it's a copy.  I would rather like to see you using the other
files.  Yet another copy means more maintenance problems.  You can
define a macro in the SH files which prevents the MIPS header from being
included.  Or maybe this is even one of the rare situations where it is
OK to test for __mips__ or whatever the symbol gcc defines is since it
is indeed only for mips you want these headers.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖



More information about the Libc-hacker mailing list