[RFA] pei386 dll: auto-import patch

DJ Delorie dj@delorie.com
Wed Aug 1 11:47:00 GMT 2001

> Ultimately, I believe the default should be "on"...eventually.

Agreed.  "Eventually" could be next week, if sufficient testing is
done.  I just get nervous about patches like this (big and tricky).
I'd rather make multiple little steps than one big one when possible.

> > The code style is wrong (binutils follows the GNU coding standards).
> I'm not sure about this; I'll go thru the code and try to make the 
> spacing line up like the surrounding code. Is there something else I'm 
> missing?

Indentation (maintly the gory debug code), spaces around identifiers
(strcmp () instead of strcmp(), a + b instead of a+b), and don't put
the if on the same line as the printf.  Run the file through indent
and see what the differences are (although you may find changes
outside your patch too, nobody's perfect ;)

> > Do not use the term "bugger" in comments.  Please stick to technical
> > names, not derogatory ones.
> ??? Where's THAT?  I'll find it and remove it.

+/* I don't know which bugger sets .idata as code */
+  {
+    asection *asec = bfd_get_section_by_name (output_bfd, ".idata");

> DJ, *thanks* for your comments.  I've been hoping someone more closely 
> allied with the main binutils development would take a look and comment 
> on this change.  I had felt that "we" have been operating in a vacuum...

No, I've been saving the emails and letting the back-n-forth settle
down so I could read them all at the same time (too many things going
on to keep every thread in my head at once).

Also, after you (or someone) demonstrate sufficient proficiency and
trust in this code, you (or someone) could volunteer to be a
maintainer of it, and be able to commit patches directly.  Something
to look forward too...

More information about the Cygwin-apps mailing list