[PATCH] Logging output of post-install scripts in setup
Igor Pechtchanski
pechtcha@cs.nyu.edu
Thu Oct 17 08:39:00 GMT 2002
Robert,
Thanks for the feedback. Let me try to address them one at a time:
On 18 Oct 2002, Robert Collins wrote:
> On Fri, 2002-10-18 at 00:02, Igor Pechtchanski wrote:
> > I changed the subject line to something more appropriate and resent to the
> > (hopefully) correct list.
> > Igor
>
> Ok, some feedback.
>
> Firstly, does this all work happily on win95? With both .bat and .sh
> scripts?
I don't have access to a Win95 machine, unfortunately... I can (and will)
test it out on Win98 to make sure it works. Would that suffice? If not,
could someone with a Win95 machine please test this?
Also, most postinstall scripts don't output anything, so I've only tested
this with gcc-mingw, which does. Which other postinstall scripts produce
output (but please, no tetex)?
> Secondly, please don't pass around char * parameters with new functions.
> You should pass around the String until you have to pass it to an OS
> call.
I've modeled the parameter passing after what was already there. run() is
not a new function, it's an old (static) function with two char*
parameters. All I did was add one more.
> Thirdly, could you break up the code a little more? The log file
> initialisation logic should live in a separate member function, with
> something like'
>
> if (l.size())
> prepareForLogging(&LOGHANDLE,...);
>
> Rob
Sure, sounds reasonable. I'll rework the patch then. The functionality
most probably won't change, though, so please test anyway it on the
platforms that I don't have access to (WinNT, WinXP, WinME, Win95... Did
I miss something?). Thanks,
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51
More information about the Cygwin-apps
mailing list