[setup PATCH] Improve Category column (Take 2)
Max Bowsher
maxb@ukf.net
Sun Sep 22 14:05:00 GMT 2002
Max Bowsher wrote:
> Robert Collins wrote:
> > Much better. Please supply as a attachment, along with a changelog.
Here.
> > > + set<String, String::caseless>::const_iterator all =
> categories.find("All");
> > this is also not needed, and if we were using something that supports
> > multiple entries (say a vector) with the same key, would give incorrect
> > results.
>
> My gut feeling was that an iterator should compare quicker than a string.
I did some speed testing - I was wrong, it turns out.
It turns out that my weird attempt at making thinks faster actually made things
_slower_. The patch is therefore remodelled.
Max.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ChangeLog-fragment
Type: application/octet-stream
Size: 378 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20020922/49936203/attachment.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: setup-categories.patch
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20020922/49936203/attachment.ksh>
More information about the Cygwin-apps
mailing list