[setup PATCH] SetDlgItemFont

Robert Collins rbcollins@cygwin.com
Fri Aug 1 23:19:00 GMT 2003


On Sat, 2003-08-02 at 09:12, Max Bowsher wrote:

> Now, I don't think moving 2 lines of code and 4 lines of comments into a
> seperate function makes this clearer - rather, it obfuscates what is
> happening here.
> 
> In case you are not convinced, here is the alternate patch, to avoid another
> round-trip of emails:
> I'm not particularly fond of the name "SetFontPolicy". Better names
> welcomed.

call it void PropertyPage::setTitleFont().

And I'm not convinced - this is appropriate to be a separate function.

Approved - as a separate function, called setTitleFont.

Cheers,
Rob


-- 
GPG key available at: http://members.aardvark.net.au/lifeless/keys.txt.
---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030801/f596dc0b/attachment.sig>


More information about the Cygwin-apps mailing list