ntsec patch for setup

Max Bowsher maxb@ukf.net
Sun Jan 19 18:25:00 GMT 2003

Pierre A. Humblet wrote:
> This is the patch mentioned in the previous e-mail. I seems
> to work fine on NT and an early version was tested on 2000 (there
> are differences).
> Essentially the installed files should be in the Users or
> Admins groups instead of None.
> Nothing changes if the user running setup does not have the
> None gid.

Sounds like this should migitate most new user's ntsec problems.

It would probably be nice to add some logging to the success case, so its
easier to see that it has actually taken effect.

I don't understand this code:
+  isadmins = isadmins || EqualSid(groups->Groups[pg].Sid, asid);
+  isusers = isusers || EqualSid(groups->Groups[pg].Sid, usid);

If I'm reading it right, isadmins and isusers were initialized as false
several lines above, and not touched since - so why not a direct assignment?


More information about the Cygwin-apps mailing list