[setup PATCH] Remove pointless, worrying log message

Max Bowsher maxb@ukf.net
Sun Jan 19 20:15:00 GMT 2003

Robert Collins wrote:
> On Mon, 2003-01-20 at 02:25, Max Bowsher wrote:
>> Code calls compress_bz::error() to ask *whether* an error has
>> occurred. It is silly and scare-mongering to print
>> "compress_bz::error called" to the log in this case.
>> Ok to commit?
> No. We really need to implement the error checking - thats why it's
> there and verbose. There was a large fixup of such messages ~ 6 months
> back - and the same discussion on this particular one.

Wouldn't a /* FIXME: */ be more appropriate here?

Or, is the idea to annoy yourself into fixing the lack of error checking?


More information about the Cygwin-apps mailing list