[setup PATCH] Remove pointless, worrying log message
Sun Jan 19 20:35:00 GMT 2003
Christopher Faylor wrote:
> On Sun, Jan 19, 2003 at 08:15:17PM -0000, Max Bowsher wrote:
>> Robert Collins wrote:
>>> On Mon, 2003-01-20 at 02:25, Max Bowsher wrote:
>>>> Code calls compress_bz::error() to ask *whether* an error has
>>>> occurred. It is silly and scare-mongering to print
>>>> "compress_bz::error called" to the log in this case.
>>>> Ok to commit?
>>> No. We really need to implement the error checking - thats why it's
>>> there and verbose. There was a large fixup of such messages ~ 6
>>> months back - and the same discussion on this particular one.
>> Wouldn't a /* FIXME: */ be more appropriate here?
>> Or, is the idea to annoy yourself into fixing the lack of error
> And not just "yourself", either. It hass worryied scores of other
> people. A FIXME sounds better to me. Either that or add a "don't
> worry about this" to the message.
How about this?: Robert and I promise to annoy each other into fixing the
lack of error checking, and I change the log to a FIXME for now.
More information about the Cygwin-apps