Review required for whitespace changes?

[Robert Collins]

On Wed, 2003-07-23 at 02:29, Max Bowsher wrote:
> May I apply whitespace changes which are in keeping with the style of
> surrounding code and the rest of setup without explicit review?
> 
> Are such things supposed to be ChangeLogged?
> 
> Example:
> -UINT Window::IsButtonChecked (int nIDButton) const
> +UINT
> +Window::IsButtonChecked (int nIDButton) const


http://www.cygwin.com/ml/cygwin-apps/2003-03/msg00750.html

IOW, no, no review for whitespace, but note that I'll likely be running
astyle (a code formatter) without notice when I get some time...

Comments that are on their own - isolated changes - should be
changelogged though, as should non-autogenerated documentation.
Why? Because doco changes also have motive - like code changes, and like
code changes the motive should be recorded.

Rob


Rob
-- 
GPG key available at: <http://members.aardvark.net.au/lifeless/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030723/a13b34c6/attachment.sig>