[setup PATCH] Another micropatch heading towards next_dialog removal (1)

[Robert Collins]

On Sat, 2003-07-26 at 20:14, Max Bowsher wrote:
> Index: ChangeLog
> ===================================================================
> RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/ChangeLog,v
> retrieving revision 2.373
> diff -u -p -r2.373 ChangeLog
> --- ChangeLog 26 Jul 2003 09:01:35 -0000 2.373
> +++ ChangeLog 26 Jul 2003 10:06:57 -0000
> @@ -0,0 +1,6 @@
> +2003-07-26  Max Bowsher  <maxb@ukf.net>
> +
> + * dialog.h: (NEXT): Remove obsolete macro.
> + * site.cc (save_dialog): Remove use of NEXT(). Replace with an exit,
> + as this is a serious but incredibly unlikely runtime error.

So, today we handle the situation, after this we don't?

It seems better to me to loop (say max 2 times) if such a race occurs,
rather than reentering the dialog or exiting.

The -only- failure case I can think of is if the user manages to
deselect all sites leading to nothing being selected when the next
handler is called. That would (presumably) be handled by returning
IDD_SITEfrom OnNext.

Rob


-- 
Robert Collins <rbcollins@cygwin.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030726/55ac5660/attachment.sig>