[Setup PATCH] Eliminate next_dialog

[Gary R. Van Sickle]

> Gary R. Van Sickle wrote:
> > Better.  Stronger.  Faster.
> >
> > 2003-07-26  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
> >
> > * dialog.h (next_dialog): Remove global variable, obsolete.
> > (do_fromcwd): Change function declaration.
> > (NEXT): Remove obsolete macro.
> > * download.cc (do_download_thread): Add next_dialog as return
> > parameter (return by reference).
> > (do_download_reflector): Call do_download_thread() with third
> > parameter.  Call Progress.PostMessage() with returned value.
> > (context): Change to struct.
> > (do_download): Change declaration and initialization of context.
> > Initialize new context member.
> > * fromcwd.cc (do_fromcwd): Change return type to bool.  Eliminate
> > use of next_dialog, return true or false instead.
> > * ini.cc (do_ini_thread): Add next_dialog as return parameter
> > (return by reference).
> > (do_ini_thread_reflector): Call do_ini_thread() with third parameter.
> > Call Progress.PostMessage() with returned value.
> > (context): Change to struct.
> > (do_ini): Change declaration and initialization of context.
> > Initialize new context member.
> > * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
> > value instead of next_dialog.
> > * main.cc (next_dialog): Remove obsolete global variable.
> 
> I have my own version this lot in the pipeline, using actual return values,
> instead of returning values in the static contexts.

Oh, yeah, what the heck.  I totally missed that.

> That, coupled with a
> removal of unused HINSTANCE parameters, will reduce the quantity of
> passed-in data to one HWND - thus allowing us to dispose of the static
> contexts entirely.
> 
> I'll be feeding this piecewise onto this list, as earlier patches clear
> Robert's reviews.
> 

So, "thanks but no thanks"?

-- 
Gary R. Van Sickle
Brewer.  Patriot.